/
PR/Merging Standards

PR/Merging Standards

This document is meant to show what our standard practice is when it comes to creating PRs in github.

 

  • Always merge from your development branch → dev

  • Always request intentional reviewer(s) for your PR

  • branch → dev requires at least 1 reviewer && dev → main requires 1 + @Mikah Pinegar

  • Once PR is created send your reviewer a slack message with the PR link so they are aware its been created.

  • All PRs should be reviewed within 24hr. If you expect a delay please reach out to the dev so they can add a different reviewer.

  • Link the issue and project in your PR

  • Create a bullet list of all changes that were made and any additional details

  • When merging a branch into dev please delete your development branch.

 

Related content

Ticket Standards
Ticket Standards
Read with this
Branching Strategies
Branching Strategies
More like this
Coding Best Practices
Coding Best Practices
Read with this
Documentation Notes
Documentation Notes
More like this
Confluence Standards
Confluence Standards
Read with this
Repository Cleanup
Repository Cleanup
More like this